Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip's "hover focus" combination behaves strangely #16008

Closed
redbmk opened this issue Mar 5, 2015 · 6 comments
Closed

Tooltip's "hover focus" combination behaves strangely #16008

redbmk opened this issue Mar 5, 2015 · 6 comments

Comments

@redbmk
Copy link
Contributor

redbmk commented Mar 5, 2015

I can create a workaround for this easily enough, but it seems like odd default behavior so I thought it should be filed as a bug. I would expect that if "hover focus" is used that the tooltip would be showing any time I am focused or hovered.

If I move the mouse over an input, it will display the tooltip. Clicking on it will focus, and it remains showing. Now if I move the mouse out then I am still focused, but the tooltip disappears. Similarly, if I hit tab to move the focus to another input without moving the mouse then I am still hovering over the first, but the tooltip disappears in this case as well.

https://jsfiddle.net/wkxanbfh/

@cvrebert cvrebert added the js label Mar 5, 2015
@hnrch02
Copy link
Collaborator

hnrch02 commented Mar 6, 2015

PRs welcome.

@redbmk
Copy link
Contributor Author

redbmk commented Mar 7, 2015

Here you go 😃

This ended up moving the changes from aac0e16 around a bit and using a slightly different method to figure out if the tooltip was already showing, but the tests still pass and I'm not able to recreate the flicker with my code changes. I was working with some older code when I did my testing and had noticed the flicker as well. Might need a bit of tweaking if the new method re-introduces some flicker, but like I said I wasn't able to recreate it.

@sgonyea, does this break any of your changes as far as you can tell?

redbmk added a commit to redbmk/bootstrap that referenced this issue Mar 7, 2015
@redbmk
Copy link
Contributor Author

redbmk commented Mar 13, 2015

@hnrch02 ,

Any chance this will get merged at some point? What kind of vetting is required first?

@kkirsche
Copy link
Contributor

@redbmk my initial guess would be its waiting for fat (Jacob I believe) to review as he is head JS dev. I'm just guessing Though

@redbmk
Copy link
Contributor Author

redbmk commented Mar 13, 2015

@kkirsche OK, thanks for the update. Just didn't want it to fall through the cracks.

@fat
Copy link
Member

fat commented Apr 27, 2015

closing in favor of the related pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants