Accordion's "at most 1 open item" invariant gets violated after using JS API

[skateman]

Hello!

When you try to collapse/expand accordions with JS, reopening the collapsed accordion by clicking causes expanding both accordions.

See http://getbootstrap.com/javascript/#collapse-example-accordion

Originally posted to: patternfly/patternfly#162

[cvrebert]

Collapse's toggle, show, and hide methods are asynchronous. It's not valid to call them twice sequentially like that. You need to wait for the hidden.bs.collapse event before making subsequent calls.

[Johann-S]

This PR would be usefull #17823 😄

[cvrebert]

Indeed! I do intend to get around to that PR, I just have a lot of things on my TODO list.

[Johann-S]

Haha it's ok good luck for your TODO list 😉

[skateman]

Same happens when I call it like this:

$("#collapseOne").one('hidden.bs.collapse', function () {
  $("#collapseTwo").collapse('show');
});
$("#collapseOne").collapse('hide');

But even if I wait between typing in the two collapse calls.

[cvrebert]

Perhaps this is related to #17335.

[cvrebert]

This also prompts the question of whether this can be fixed in v3 given that some folks might be relying on the "broken" behavior.

[Johann-S]

IMO we should add data-parent in the collapse element because we allow user to toggle collapse element without passing by the <a> which contain the data-parent attribut.
That's why the collapse behavior is strange because they are no parent

[pvdlg]

X-ref #21726