Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back functionality to open accordion from the presenter #5693

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 3, 2015

@skateman
Copy link
Member Author

skateman commented Dec 4, 2015

Blocked by: twbs/bootstrap#18418

@skateman
Copy link
Member Author

skateman commented Dec 7, 2015

The bootstrap bug is still present, but because it's a high priority issue, I used a workaround.

@skateman
Copy link
Member Author

skateman commented Dec 7, 2015

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Dec 7, 2015
@skateman skateman changed the title [WIP] Add back functionality to open accordion from the presenter Add back functionality to open accordion from the presenter Dec 7, 2015
@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2015

Checked commit skateman@46d7d11 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@skateman
Copy link
Member Author

@romanblanco please review

@romanblanco
Copy link
Member

Tested in UI, fixes the bug. 👍

martinpovolny added a commit that referenced this pull request Dec 10, 2015
Add back functionality to open accordion from the presenter
@martinpovolny martinpovolny merged commit 4e173d5 into ManageIQ:master Dec 10, 2015
@martinpovolny martinpovolny added this to the Sprint 34 Ending Dec 28, 2015 milestone Dec 10, 2015
@skateman skateman deleted the bug-1287584 branch December 10, 2015 14:27
dclarizio pushed a commit that referenced this pull request Dec 17, 2015
…ng_open

Following commit for PR #5693 catalog item accordion not opening
simon3z pushed a commit to simon3z/manageiq that referenced this pull request Dec 21, 2015
 Unexpected error occurred on Cloud Intelligence -> Reports -> Dashboards page and Catalog Accordion fix

Clean cherry pick for:
ManageIQ#5693
ManageIQ#5892

5.5 BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1289697

See merge request !641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants