Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-align: left to .form-control #19379

Closed
Mevrael opened this issue Mar 3, 2016 · 5 comments
Closed

Add text-align: left to .form-control #19379

Mevrael opened this issue Mar 3, 2016 · 5 comments
Labels

Comments

@Mevrael
Copy link

Mevrael commented Mar 3, 2016

.form-control does not have text-align and because of that text-align might be inherited from parent element. Inputs should have text-align: left by default.

.form-control used as a div contenteditable=true

    <div class="form-group">
        <div contenteditable="true" class="form-control"></div>
        <input type="hidden">
    </div>
@cvrebert
Copy link
Collaborator

cvrebert commented Mar 3, 2016

What about RTL text/pages?

@cvrebert cvrebert changed the title [v4] Add text-align: left to .form-control Add text-align: left to .form-control Mar 3, 2016
@Mevrael
Copy link
Author

Mevrael commented Mar 3, 2016

In RTL you will need in any case add styles like direction:RTL, text-align: right and is a good idea for .form-control-right

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 3, 2016

X-Ref: #17925

@Mevrael
Copy link
Author

Mevrael commented Mar 3, 2016

The only one input[type="number"] should not have right align if rest is aligned to left. From design and UX point of all elements must have same structure and proportions. It is the same as making selects also align to right only because they have arrow button there. I agree that helper here would be better choice because it is only for one specific decorative case.

@mdo
Copy link
Member

mdo commented Apr 11, 2016

Going to punt on this—I'd rather leave it inherited as it's the browser default.

@mdo mdo closed this as completed Apr 11, 2016
@ffoodd ffoodd mentioned this issue Jun 8, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants