Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4 css] Collapsed navbar toggle moves to awkward position #21590

Closed
sejr opened this issue Jan 7, 2017 · 4 comments
Closed

[v4 css] Collapsed navbar toggle moves to awkward position #21590

sejr opened this issue Jan 7, 2017 · 4 comments

Comments

@sejr
Copy link

sejr commented Jan 7, 2017

I am using a navbar with only a brand image; no brand name (as shown above). You can see that the collapse button is clearly out of place, over my brand image.

Expected

The collapse toggle should remain right-floated regardless of viewport width.

Also...

Does anyone else think that the toggle collapse button should be redesigned? For instance, on dark backgrounds it should be lighter (maybe completely white). I'd also be interested in seeing the border disappear — it is always a hassle to figure out the specific CSS heirarchy to modify it.

@sejr sejr changed the title Collapsed navbar toggle moves to awkward position [v4 css] Collapsed navbar toggle moves to awkward position Jan 7, 2017
@sejr
Copy link
Author

sejr commented Jan 7, 2017

It seems I can't replicate this issue on my actual iPhone when the application is in production. (This particular screenshot was taken from Chrome DevTools.)

@jnizet
Copy link

jnizet commented Jan 7, 2017

I had the same issue. It happens when there is a .container inside the .navbar, and when .navbar-toggler-right is used.

@sejr
Copy link
Author

sejr commented Jan 7, 2017

And isn't .container inside a navbar the correct way to align it? Not sure if there may be a new replacement.

@svenluijten
Copy link

I've posted a fix for this behaviour in #21605. Simply add this to your custom CSS file:

@include media-breakpoint-down(xs) {
    .container {
        margin-left: 0;
        margin-right: 0;
    }
}

@mdo mdo mentioned this issue Jan 21, 2017
@mdo mdo added this to the v4.0.0-beta milestone Jan 21, 2017
@mdo mdo added the has-pr label Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants