Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23100: Add xs: 100% in $container-max-widths #23106

Merged
merged 3 commits into from
Aug 4, 2017

Conversation

chiraggmodi
Copy link
Contributor

Fix issue mention in #23100, i have added xs: width 100% in _variable.scss file $container-max-widths.

@gijsbotje
Copy link
Contributor

I think the fix that was provided in the issue you mentioned is a better fix
He proposed to make width: 100% a default for .container and only use max-width for the breakpoints

@chiraggmodi
Copy link
Contributor Author

so this PR is good, right? no need to change as per his suggestion?

@gijsbotje
Copy link
Contributor

you added a xs value to the container-max-widths map
what #23100 suggest is chaging the function that creates the sass for every breakpoint to only contain the max-width property, and to set width: 100% on .container

@chiraggmodi
Copy link
Contributor Author

chiraggmodi commented Jul 18, 2017

@gijsbotje have made change as per suggestion in #23100 sorry for multiple PR

@mdo mdo added this to the v4.0.0-beta milestone Aug 4, 2017
@mdo
Copy link
Member

mdo commented Aug 4, 2017

Digging this change for Beta 1—testing and will merge with some additional changes shortly. Here's a quick recap on why it's helpful:

With this PR, we can remove both those previous fixes for the original navbar issue, thereby fixing all containers in and outside navbars.

@mdo mdo merged commit b271204 into twbs:v4-dev Aug 4, 2017
@chiraggmodi
Copy link
Contributor Author

Thanks for merging
and did you have any idea how could i see all contributor list of this project.
on this URL only top 100 contributors are displaying.
https://github.com/twbs/bootstrap/graphs/contributors

@chiraggmodi chiraggmodi deleted the issue_23100 branch August 22, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants