Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btn-toolbar - btn-group - content doesn't fit to content on mobile view #21699

Closed
Lausselloic opened this issue Jan 13, 2017 · 1 comment
Closed

btn-toolbar - btn-group - content doesn't fit to content on mobile view #21699

Lausselloic opened this issue Jan 13, 2017 · 1 comment
Labels
css has-pr v4
Milestone
v4.0.0-beta

Comments

@Lausselloic
Copy link
Contributor

In alpha.6 btn-toolbar content doesn't wrap to container size.

This example from the doc http://v4-alpha.getbootstrap.com/components/button-group/#button-toolbar
Lock the container size and an horizontal scrollbar appear. In alpha.5 btn-toolbar content fits well

Here is the jsfiddle : https://jsfiddle.net/L84dbasj/

Is it due to flexbox, and that component is not rewritten in alpha.6?
Lausselloic added a commit to Orange-OpenSource/Orange-Boosted-Bootstrap that referenced this issue Jan 13, 2017
@Lausselloic
docs(btn-toolbar): add a flex-wrap class to btn-toolbar waiting for a…
91b6ca7 
… better solution if exists see bootstrap issue twbs/bootstrap#21699
@mdo mdo added this to the v4.0.0-beta milestone Jan 24, 2017
@mdo mdo added the has-pr label Jan 24, 2017
mdo added a commit that referenced this issue Jan 24, 2017
@mdo
Allow button toolbars to wrap
86c0b00 
Fixes #21699
@mdo mdo mentioned this issue Jan 24, 2017
Merged
@mdo mdo mentioned this issue Jan 25, 2017
Closed
mdo added a commit that referenced this issue Jan 25, 2017
@mdo
Allow button toolbars to wrap (#21826)
9d7d84e 
Fixes #21699
@Lausselloic
Copy link
Contributor Author

Thanks for the fix for btn-toolbar, but maybe also need to allow .btn-group to wrap?

At least for the sample of custom checkbox and radio : https://v4-alpha.getbootstrap.com/components/buttons/#checkbox-and-radio-buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
3 participants
@mdo @bardiharborow @Lausselloic