-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move .custom-select styles to select.form-control #23058
Comments
Let's slate this for a follow up minor release; we can deprecate it later. |
Merged
20 tasks
pi0
pushed a commit
to bootstrap-vue/bootstrap-vue
that referenced
this issue
Jan 23, 2018
…ol, and will fully support control sizing (sm & lg) twbs/bootstrap#23058
That would be nice. Now .custom-select-* does not play nice with .form-control. And if I'd want to override some general controls style it would be simpler and smaller to do this for .form-control only. |
Pada tanggal Sel, 22 Mei 2018 15.40, Aleksander Machniak <
[email protected]> menulis:
… That would be nice. Now .custom-select-* does not play nice with
.form-control. And if I'd want to override some general controls style it
would be simpler and smaller to do this for .form-control only.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23058 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlFieRTh4xL1rMIc3FM2ZauJWtsHWK3Qks5t087hgaJpZM4OWEAR>
.
|
This was fixed in #28450 for v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is it possible to move
.custom-select
styles toselect.form-control
? As it stands, it's only really useful if you don't plan on changing the border-radius on form-controls. By adding theform-control
class to the select element we are already committing to Bootstrap's contract to style the element, doesn't make sense why we would only have partial control.Edit: Also,
.custom-select
is the only custom element that doesn't need an extra element to achieve custom styles.The text was updated successfully, but these errors were encountered: