Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .custom-select styles to select.form-control #23058

Closed
pat270 opened this issue Jul 12, 2017 · 4 comments
Closed

Move .custom-select styles to select.form-control #23058

pat270 opened this issue Jul 12, 2017 · 4 comments

Comments

@pat270
Copy link
Contributor

pat270 commented Jul 12, 2017

Is it possible to move .custom-select styles to select.form-control? As it stands, it's only really useful if you don't plan on changing the border-radius on form-controls. By adding the form-control class to the select element we are already committing to Bootstrap's contract to style the element, doesn't make sense why we would only have partial control.

Edit: Also, .custom-select is the only custom element that doesn't need an extra element to achieve custom styles.

@mdo
Copy link
Member

mdo commented Aug 4, 2017

Let's slate this for a follow up minor release; we can deprecate it later.

pi0 pushed a commit to bootstrap-vue/bootstrap-vue that referenced this issue Jan 23, 2018
@alecpl
Copy link
Contributor

alecpl commented May 22, 2018

That would be nice. Now .custom-select-* does not play nice with .form-control. And if I'd want to override some general controls style it would be simpler and smaller to do this for .form-control only.

@romieleo
Copy link

romieleo commented May 22, 2018 via email

@mdo
Copy link
Member

mdo commented Jul 13, 2019

This was fixed in #28450 for v5.

@mdo mdo closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants