Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: the way to apply fix for SVG images w/ .img-fluid in IE 9-10 automatically #23476

Closed
juliyvchirkov opened this issue Aug 15, 2017 · 4 comments
Labels

Comments

@juliyvchirkov
Copy link

juliyvchirkov commented Aug 15, 2017

as declared at https://getbootstrap.com/docs/4.0/content/images/ IE 9-10 sizes SVG images w/ .img-fluid disproportionately, but no fix is applied automatically 'cause the offered workaround fixes responsivity for SVG images on one hand but breaks it for other image formats on another

2017-08-16 00 10 56

the proposal is to add

.img-fluid[src$=.svg] {
    width: 100% \9;
}

since the fix «width: 100% \9» is targeted to IE & ignored as malformed by other browsers, & the selector «src$=.svg» forces the rule to be applied only if image url in src attribute has «svg» extension, this should achieve the goal

@chiraggmodi
Copy link
Contributor

we have dropped support for IE 9, so I don't think it is necessary to add

@juliyvchirkov
Copy link
Author

juliyvchirkov commented Aug 16, 2017

yep, as I see IE9 support has been dropped, but beta 4.0 still declares the support for IE10 https://getbootstrap.com/docs/4.0/getting-started/browsers-devices/

2017-08-16 14 09 31

so since the IE10 inherits the bug on SVG proportions w/ .img-fluid from v9 while percent of SVG images is widely growing nowadays, maybe there's a reason to apply the workaround for v10 till the support for IE will be dropped completely

@Herst
Copy link
Contributor

Herst commented Aug 17, 2017

IE9 was dropped in December (see #21416) but IE10 was not; however, people were told to "keep the feedback coming in".

@mdo
Copy link
Member

mdo commented Apr 1, 2018

No plans to add this automatically at this point. Have heard very few issues about this one since originally opening and don't want to cause more confusion by making it the default now. Thanks though!

@mdo mdo closed this as completed Apr 1, 2018
coliff added a commit to coliff/bootstrap-ie8 that referenced this issue May 18, 2018
/* REF: twbs/bootstrap#23476 */
  .img-fluid[src$=".svg"] {
    width: 100% \9;
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants