Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button focus outline color #23822

Closed
ysds opened this issue Sep 4, 2017 · 4 comments
Closed

Button focus outline color #23822

ysds opened this issue Sep 4, 2017 · 4 comments

Comments

@ysds
Copy link
Member

ysds commented Sep 4, 2017

I prefer the button's focus outline color is different from the background(border) color. Because the outline can not be seen in the case of a solid button group (btn btn-primary etc.).

Current:
image

Lighter example:
image

@andresgalante
Copy link
Collaborator

Focus colors are always variables. For example for btns:
https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss#L311-L312

You can always change them and recompile if you want.

@ysds
Copy link
Member Author

ysds commented Sep 9, 2017

Yes. But I think it should be visible by default.

@mdo
Copy link
Member

mdo commented Oct 20, 2017

Unsure how best to proceed on this... perhaps we saturate or tint the focus shadow instead of using a regualr alpha-transparent theme color?

@ysds
Copy link
Member Author

ysds commented Oct 23, 2017

@mdo Please check the PR. But it not match to outline's focus color. It is better to have the same color for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants