Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligthen/Darken Button focus shadow color #24507

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Ligthen/Darken Button focus shadow color #24507

merged 2 commits into from
Nov 4, 2018

Conversation

ysds
Copy link
Member

@ysds ysds commented Oct 23, 2017

Fixes #23822

@XhmikosR XhmikosR requested a review from mdo October 23, 2017 09:05
@XhmikosR
Copy link
Member

XhmikosR commented Nov 4, 2018

@ysds: can you fetch upstream and rebase please?

@ysds ysds requested review from a team as code owners November 4, 2018 12:23
@ysds
Copy link
Member Author

ysds commented Nov 4, 2018

oh... my bad

@XhmikosR XhmikosR removed the request for review from mdo November 4, 2018 12:37
MartijnCuppens
MartijnCuppens approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @ysds!

@mdo mdo mentioned this pull request Nov 4, 2018
Closed
@XhmikosR XhmikosR merged commit 4a1090a into twbs:v4-dev Nov 4, 2018
@ysds ysds deleted the button-focus-shadow-color branch January 7, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysds @XhmikosR @MartijnCuppens @Johann-S