Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor our npm scripts #24121

Closed
XhmikosR opened this issue Sep 26, 2017 · 3 comments
Closed

Refactor our npm scripts #24121

XhmikosR opened this issue Sep 26, 2017 · 3 comments

Comments

@XhmikosR
Copy link
Member

OK, so currently, I find it quite annoying that

  1. I need to open 2 separate cmds to do local development (one with bundle exec jekyll watch and another one with npm run watch)
  2. Most importantly, I feel like our scripts don't include important parts.

When I do npm run css it makes sense to me to run the docs-css script too, and so on.

Opening the issue to track it and to find solutions to improve this.

/CC @Johann-S @bardiharborow

@bardiharborow
Copy link
Member

When I was building this, I had significant issues trying to imagine the most common groups of tasks you'd want to run, and some commands may be suboptimal. My only request is that when refactoring, you trying to keep internal consistency within the commands as a system. Happy to have a shoot at this tomorrow if I remember to do so (I need to stop self-assigning things and then never finishing them though).

@XhmikosR
Copy link
Member Author

XhmikosR commented Sep 26, 2017

We definitely need to address the second point above. The watch situation is also annoying but it affects us for now, while if we miss running a script it will affect the users.

Feel free to ping me if you make any progress.

@mdo
Copy link
Member

mdo commented Sep 26, 2017

My setup right now requires three tabs in Terminal (not complaining, totally fine with that):

  1. bundle exec jekyll serve
  2. npm run watch
  3. Git commands and whatever else

If there's a way to knock it down to two, I'm in favor, but perhaps documenting these better could be helpful, too?

This was referenced Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants