Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak npm scripts. #24146

Merged
merged 2 commits into from
Oct 1, 2017
Merged

Tweak npm scripts. #24146

merged 2 commits into from
Oct 1, 2017

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 27, 2017

  • make css and js "super" scripts which will run both main and docs scripts
  • make js-minify run all js minify tasks
  • use parallel in more places

It's a first pass but I think it covers more cases than before.

Suggestions to improve this are welcome!

Fixes #24121

* make `css` and `js` "super" scripts which will run both main and docs scripts
* make `js-minify` run all js minify tasks
* use parallel in more places
@XhmikosR
Copy link
Member Author

So what should I do with this, guys?

@mdo @bardiharborow @Johann-S

Copy link
Member

@bardiharborow bardiharborow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane to me, provided you've tested it.

@XhmikosR XhmikosR merged commit 202cd09 into v4-dev Oct 1, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-npm-scripts branch October 1, 2017 08:09
@mdo mdo mentioned this pull request Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants