Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Review necessarity of warning about customizing values form-valiation-state mixin #32082

Closed
ydmitry opened this issue Nov 8, 2020 · 1 comment · Fixed by #35827 or javascript-indonesias/bootstrap#461

Comments

@ydmitry
Copy link
Contributor

ydmitry commented Nov 8, 2020

Wanted to ask about phrase in the docs in /site/content/docs/5.0/forms/validation.md:

Please note that we do not recommend customizing these values without also modifying the `form-validation-state` mixin.

Should we keep this? Why need to modify a mixin? Seems should be OK now without modifying. What do you think?

Originally posted by @ydmitry in #31757 (comment)

@ffoodd
Copy link
Member

ffoodd commented Nov 25, 2020

I guess it's related to the pseudo-classes, which used to be generated even when it wasn't valid or invalid (resulting in invalid selectors). It's been fixed in #28447 1.5 years ago — and now outputs .is-#{$state} instead of ``:#{$state}`.

So the sentence you're pointing can be safely removed IMHO.

mdo added a commit that referenced this issue Feb 11, 2022
Remove sentence in docs that's no longer needed. Fixes #32082.
@mdo mdo mentioned this issue Feb 11, 2022
@mdo mdo added the has-pr label Feb 11, 2022
mdo added a commit that referenced this issue Feb 11, 2022
Remove sentence in docs that's no longer needed. Fixes #32082.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants