Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode: btn-outline-dark is not visible and btn-dark has no border for user discoverability #37711

Closed
3 tasks done
jadeops opened this issue Dec 25, 2022 · 2 comments
Closed
3 tasks done

Comments

@jadeops
Copy link

jadeops commented Dec 25, 2022

Prerequisites

Describe the issue

Peek 2022-12-25 14-25

Peek 2022-12-25 14-29

Reduced test cases

See above

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v5.3.0-alpha

@jadeops
Copy link
Author

jadeops commented Dec 25, 2022

Hmmm, Bug 3: seems like btn-outline-light is not visible on the light mode. https://getbootstrap.com/docs/5.3/components/buttons/#outline-buttons

Just read the note: "Some of the button styles use a relatively light foreground color, and should only be used on a dark background in order to have sufficient contrast."

I am not sure if this is a bug now. I think I ll get rid of all btn*dark and btn*light in my code base to avoid these issues. Feel free to close this if invalid.

@mdo
Copy link
Member

mdo commented Dec 25, 2022

This is intentional for now, as you've mentioned :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants