Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode: btn-outline-dark is not visible in button group component #37753

Closed
3 tasks done
Tracked by #37549
teaca-sebastian opened this issue Dec 29, 2022 · 2 comments · Fixed by #37757
Closed
3 tasks done
Tracked by #37549

Darkmode: btn-outline-dark is not visible in button group component #37753

teaca-sebastian opened this issue Dec 29, 2022 · 2 comments · Fixed by #37757

Comments

@teaca-sebastian
Copy link
Contributor

teaca-sebastian commented Dec 29, 2022

Prerequisites

Describe the issue

https://getbootstrap.com/docs/5.3/components/button-group/#sizing
https://getbootstrap.com/docs/5.3/components/buttons/

The bug is pretty self-explainatory, this happens because .btn-light .btn-dark .btn-outline-light & .btn-outline-dark don't change with data-bs-theme="dark", and there is no "body" color to change along with the data attribute. To properly solve this issue .btn-body and .btn-outline-body classes should be added to complement the darkmode feature.

Screenshot_20221229_075540
Screenshot_20221229_075548

Reduced test cases

See above

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

v5.3

@julien-deramond
Copy link
Member

FYI case 2 is a duplicate of #37711. It can be removed from your description. However I don't think case 1 has already been mentioned somewhere. Thanks for that @teaca-sebastian

@teaca-sebastian teaca-sebastian changed the title Buttons not visible on darkmode Darkmode: btn-outline-dark is not visible in button group component Dec 29, 2022
@threehymns
Copy link

threehymns commented Jan 27, 2023

@mdo, for the purposes of other sites using bootstrap, we should still add something like .btn-outline-body and .btn-body for buttons with neutral colors that adapt to dark mode. I honestly don't like those tag names much as they sound too generic because the body part does not sound like a color, so I might suggest something like .btn-outline-monochrome or .btn-monochrome. It would be great if someone could find a better name for these potential components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants