Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the URL with the Custom Build ID in the generated source files #9951

Closed
potch opened this issue Aug 20, 2013 · 10 comments · Fixed by #13205
Closed

Put the URL with the Custom Build ID in the generated source files #9951

potch opened this issue Aug 20, 2013 · 10 comments · Fixed by #13205
Milestone

Comments

@potch
Copy link

potch commented Aug 20, 2013

The new site has the awesome customization screen, but unless you manage your bookmarks like a champ, there's no clear mapping between which custom builds on your system correspond to which URLs on the site. It would rock socks if the URL of the custom build was in the header comment in the generated source files.

For example, In bootstrap.css, you could have something like:

/*!
 * Bootstrap v3.0.0
 * Custom build generated by http://getbootstrap.com/customize/?id=6277349
 * 
@cvrebert
Copy link
Collaborator

The customizer was supposed to output the build config to a Gist; don't know what happened with that...

@potch
Copy link
Author

potch commented Aug 20, 2013

@cvrebert I believe it is, that is the gist ID referred to in the above customization URL. I'd just like files generated by that URL to reference it in some way. Once you have a few projects going, remembering which 7 digit number is which is tricky.

@cvrebert
Copy link
Collaborator

I mean that we oughtta be hyperlinking to the actual Gist somewhere on the customizer page (post-generation) (but apparently aren't).

@Merg1255
Copy link

Nice. But put the url in the css file? It would be better to generate a txt file with even more info.

@NinoD
Copy link

NinoD commented Aug 26, 2013

I second the motion.

  1. for how long IDs settings will be saved?
  2. I'd preffer having my customizer settings downloaded and saved localy, for safe keeping and reviewing.

*issue #9831

@stuartpb
Copy link
Contributor

Yeah, I think including the JSON content in the .zip, as well as the URL in a comment in the output, would be swell.

@stuartpb
Copy link
Contributor

Here are my ideas for improvements:

  • Include config.json (the one that gets POSTed to Gist) in bootstrap.zip.
  • After the AJAX POST to Gist returns, add a status callout to the page saying that the config.json has been uploaded to Gist as (Gist URL), and that the customizer can be reused for that Gist via (customizer URL + '?id=' + Gist ID).

I can do a patch for this. My thinking is that waiting for the potential server response to concatenate the customizer / Gist URLs to the relevant files would unnecessarily slow down and complicate the file output flow:

  • If a developer just wants a snapshot of their selected options, the included config.json gives that to them.
  • If a developer wants to keep a note of where the configuration is stored online, they can copy the URLs from the callout to the output's comment block(s), or wherever they're keeping their development notes.
  • If a developer's Bootstrap development flow is complex enough to merit repeated output of the Gist URL to their output comments every time, they should probably be doing their Bootstrap customization / compilation locally instead of using the online customizer anyway.

Additionally, behind an "include source and map for debugging" toggle, you could include a LESS file of the customized variables, the source LESS files, and a source map for the minified files (and maybe even inline comments in bootstrap.css).

@stuartpb
Copy link
Contributor

stuartpb commented Oct 3, 2013

Any word on integrating the pull requests for this I posted three weeks ago?

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 4, 2013

@stuartpb Sorry man. @fat, our main JS guy, is pretty pressed for time lately, hence the lack of action. We appreciate your patience; please continue to hang tight!

@stuartpb
Copy link
Contributor

Thanks! What about #10632?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants