Add mixin make-container() similar to make-row()

[whazap]

When using the mixins make-row() & make-column() instead of using .row & .col- classes, i was missing the same for creating a page container.

[cvrebert]

@screen-sm etc. have been deprecated; see the comments near their declarations in the git HEAD version.

[ggam]

I think your mixin is a bit rigid. Calling make-container will create containers only for the core default breakpoints, but what if someone adds custom breakpoints? Some people are already asking for another breakpoint at 480px on #10203.

I'd prefer something like, ad advertise the user that he has to manually call it for every breakpoint

.make-container(@gutter: @grid-gutter-width; @min-width; @max-width) {
  .clearfix();
  margin-right: auto;
  margin-left: auto;
  padding-right: (@gutter / 2);
  padding-left: (@gutter / 2);

  @media (min-width: @min-width) {
    max-width: @max-width;
  }
}

Also, as BS3 is mobile-first, fluid container should be the default. So I propose to rename your make-container to make-container-fixed and make-container-fluid to make-container.

PS: don't forget to remove container-fixed at https://github.com/whazap/bootstrap/blob/82be6299b2cd4f91a77ad6f11fef8d6d88805ad6/less/mixins.less#L545

[whazap]

great input, thanks, i will change the names of the mixins remove .container-fixed and do something similar to your mixin

[ggam]

You don't seem to be using this mixin anywhere. I propose you to remove it.

[whazap]

i don't know how that one slipped in :) will do

[ggam]

I've made some more comments. Sorry for posting/deleting so much times :( hehe.

[dminkovsky]

Something like this would be pretty clutch for me too. Right now there's no way to use container as a mixin, that I'm aware of, with basic LESS. I even posted to StackOverflow but have had no luck.

What's important for me is seeing this solution incorporate the .container @media queries . As I read the patch proposed here, that doesn't seem to be the case.

[whazap]

@dminkovsky it does what you are asking for.

#element {
  .make-container-fixed();
}
or
#element {
  .container;
}

[dminkovsky]

@whazap: yes, you are right, this PR does let me use .make-container-fixed() or .container.

I proposed a simpler PR over at #10483 that would be a stepping-stone to this one. My goal is to be able to use .container as a mixin.

[dminkovsky]

Why'd you close this PR?

[ghost]

Ez létrehoz egy csomó duplikált kódot hívott make-konténer minden töréspont kívülről sajátos média ?

[ghost]

+. Make-tartály fix egyedi (@ képernyő sm-min, @ konténer-tabletta, @ ereszcsatorna);Minden töréspont Kívülről sajátos média?