add responsive CSS to hyperlinked images when thumbnail caption markup used #10662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p is used When thumbnail caption markup is used in combination with a hyperlinked image, the image is not responsive. (non-hyperlinked images are fine, like the example in the docs) Adding a selector to apply responsiveness to hyperlinked images when thumbnail captions are used.
|
The original intention of the thumbnails for linked images is that the link would be the entire I'd really rather not complicate it further, but I'm open to revisiting this in our next-next release (v3.0.2). |
mdo
added a commit
that referenced
this pull request
Dec 2, 2013
add responsive CSS to hyperlinked images when thumbnail caption markup used
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
add responsive CSS to hyperlinked images when thumbnail caption markup used
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
add responsive CSS to hyperlinked images when thumbnail caption markup used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caption markup is used in thumbnails like here http://getbootstrap.com/components/#thumbnails-custom-content, non-hyperlinked images are properly responsive. If you hyperlink the image when using caption markup (like in the default thumbnail example), the image is not responsive because the .thumbnail selector is moved up one level and .thumbnail > img no longer applies to the image.
This fix adds a new selector for responsive images for the case when you wish to use a hyperlinked image followed by a caption.