Simplifying Glyphicons #10910
Closed
Simplifying Glyphicons #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much cleaner to user `<i>` instead of `<span>` and for the class to be `.icon` instead of `.glyphicon` Also added in a lot of extras on the baseclass that will handle how the icons are displayed cross-browser. Set them to not allow for highlighting by the user.
|
Even if we wanted to, we cannot make most of these changes until Bootstrap v4 due to backwards compatibility constraints. |
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; /* Will correct font-weight begining in FF 25 */ |
There was a problem hiding this comment.
Consider opening a separate pull request for these property additions.
|
In part a duplicate of #10201. |
|
Is there a way to request this added to v4, are you guys keeping track of that stuff somewhere? Also, I feel like this is one time where using chained classes would be acceptable? |
|
(To clarify, your property additions would be eligible for consideration for v3.1.0.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much cleaner to user
<i>instead of<span>and for the class to be.iconinstead of.glyphiconAlso added in a lot of extras on the baseclass that will handle how the icons are displayed cross-browser. Set them to not allow for highlighting by the user.