Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grunt/.jshintrc #12760

Merged
merged 1 commit into from
Feb 18, 2014
Merged

Improve grunt/.jshintrc #12760

merged 1 commit into from
Feb 18, 2014

Conversation

zlatanvasovic
Copy link
Contributor

  • Remove asi: false as it's default.
  • Alphabetize properties.

@XhmikosR
Copy link
Member

LGTM

@cvrebert
Copy link
Collaborator

I favor leaving asi: false in for explicitness.

@zlatanvasovic
Copy link
Contributor Author

No need, developers will already know that from the CONTRIBUTING.md.

2014-02-16 20:48 GMT+01:00 Chris Rebert [email protected]:

I favor leaving asi: false in for explicitness.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12760#issuecomment-35208387
.

Zlatan Vasović - ZDroid

@XhmikosR
Copy link
Member

No problem with leaving it either. I prefer being explicit too.

@zlatanvasovic
Copy link
Contributor Author

Any news about this and #12758?

@cvrebert cvrebert added this to the v3.2.0 milestone Feb 18, 2014
cvrebert added a commit that referenced this pull request Feb 18, 2014
@cvrebert cvrebert merged commit 27de737 into twbs:master Feb 18, 2014
@zlatanvasovic zlatanvasovic deleted the grunt-jshintrc branch March 1, 2014 20:40
@mdo mdo mentioned this pull request Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants