Fix for issue #12854 on push and pull resets #12863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The col-*-push-0 and col-*-pull-0 classes try to reset the positioning using 0% but this prevents the opposite direction positioning to freeze and not being set correctly. To fix that, these must set the position to auto instead of 0% with means left:auto and right:auto instead of left:0% and right:0%.
mdo
added a commit
that referenced
this pull request
Mar 4, 2014
Fix for issue #12854 on push and pull resets
|
Right on. |
|
You are welcome mdo. Thanks for your great framework. |
ithcy
pushed a commit
to stevelaz/bootstrap
that referenced
this pull request
Mar 6, 2014
* upstream/master: (45 commits) fix twbs#12936 Run `grunt update-shrinkwrap` [email protected] Fixes twbs#12901: Refactors list group active state for use on non-anchors nav Fixes twbs#12848: Account for and document progress bars at 0-3% use full version number in deprecation note clarify deprecation /cc @cvrebert Fixes twbs#12697: Document readonly inputs docs for twbs#12873 grunt after merging twbs#12917 Grunt after merging twbs#12863 grunt Fixes twbs#12868: Enables icon feedback on validation states for large/small inputs. Fixes twbs#12913: Remove scoped media queries from custom xs grid mixins Fixes twbs#12914: Darken immediate children hr elements in jumbotrons Fixes twbs#12916: Don't let .lead resize on viewport change add svg logos to brand guidelines Update csscomb properties. 'colon-spac'e and 'stick-brace' don't take boolean values. grunt ... Conflicts: dist/css/bootstrap.css.map dist/css/bootstrap.min.css
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Fix for issue twbs#12854 on push and pull resets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The col--push-0 and col--pull-0 classes try to reset the positioning using 0% but this prevents the opposite direction positioning to freeze and not being set correctly.
To fix that, these must set the position to auto instead of 0% with means left:auto and right:auto instead of left:0% and right:0%.