Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler #16263

Merged
merged 1 commit into from
Apr 10, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Apr 9, 2015

Fixes #16090.
CC: @patrickhlauke @hnrch02 @XhmikosR for review

@cvrebert cvrebert added the js label Apr 9, 2015
@cvrebert cvrebert added this to the v3.3.5 milestone Apr 9, 2015
@XhmikosR
Copy link
Member

XhmikosR commented Apr 9, 2015

LGTM

I wasn't aware of that issue at all up until now :/

@patrickhlauke
Copy link
Member

LGTM

cvrebert added a commit that referenced this pull request Apr 10, 2015
Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler
@cvrebert cvrebert merged commit e5520f9 into master Apr 10, 2015
@cvrebert cvrebert deleted the fix-16090 branch April 10, 2015 23:51
@cvrebert cvrebert mentioned this pull request Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow Keydown event triggers click event for all [role="menu]
3 participants