-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo jumbotron padding #16477
Redo jumbotron padding #16477
Conversation
- In general, there are very few instances that would require a jumbotron without a parent or child container. - Right now we account for that behavior though with some horizontal padding on the .jumbotron class. - This removes that horizontal padding as it narrows our grid classes unnecessarily and accounts for a super small use case. - It also improves consistency across breakpoints, in that padding isn't being added and removed. - In doing so, I also removed the shorthand padding property and went with the specific ones (because yay specificity).
@mdo Awesome 👍 |
This was a surprise in 3.3.5. Removing the left padding on mobile devices leaves the jumbotron content looking unbalanced to me. Case in point, see http://getbootstrap.com/components/#jumbotron with a narrow viewport or mobile device. |
@inopinatus Good point. There are 2 main usecases for jumbotrons (inner container, outer container). We made the first act consistently and sensibly relative to the grid layout, but the second was broken. The fix is easy enough though, should amount to changing jumbotron.less line 28ff to .container &,
.container-fluid & {
border-radius: @border-radius-large; // Only round corners at higher resolutions if contained in a container
padding-left: (@grid-gutter-width / 2);
padding-right: (@grid-gutter-width / 2);
/*
padding-left: (@jumbotron-padding * .6);
padding-right: (@jumbotron-padding * .6);
*/
} I would personally prefer that the left/right padding depends on the grid's gutter variable rather than the jumbotron's, but that's up to the maintainers. See http://jsbin.com/goquvahito/edit?css,output for how the compiled version acts in both cases. |
As @inopinatus said
|
@freddyboucher did you read my response? It definitely is a bug. It's easy to fix though. |
@rlindner81 |
Please open a new issue with a JS Bin example demonstrating the bug and fix <3. |
Fixes #16374.
.jumbotron
class.padding
as it narrows our grid classes unnecessarily and accounts for a super small use case.padding
isn't being added and removed.padding
property and went with the specific ones (because yay specificity)./cc @rlindner81