Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #15697 — Change CSS Caret border-top from dashed to solid #16658

Closed
wants to merge 1 commit into from

Conversation

kkirsche
Copy link
Contributor

Fix #16657

Reverts #1597 which fixed #15682

EDIT:
Is it worth adding a short inline comment why this is solid not dashed?

@cvrebert cvrebert added the css label Jun 17, 2015
@@ -10,7 +10,7 @@
height: 0;
margin-left: 2px;
vertical-align: middle;
border-top: @caret-width-base dashed;
border-top: @caret-width-base solid;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the next line unnecessary; please delete the now-redundant next line.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please apply this fix to line 189 too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed redundant line(s) (one on this and one at 189) and made the change to line 189. Sorry about missing those

@mdo
Copy link
Member

mdo commented Jun 18, 2015

That other issue had a JS Bin example, was this tested in Windows and OS X versions of all browsers?

@kkirsche
Copy link
Contributor Author

I don't have access to a windows machine to test this on, I have tested this in OS X on Firefox, Safari, Opera, and Chrome. In OS X though there is no noticeable difference between the two caret styles that I could tell in the latest versions of each of these browsers.

@cvrebert
Copy link
Collaborator

This is on hold due to the lack of confirmation in #16657.

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 3, 2015

Closing since we haven't been able to confirm/reproduce #16657.

@cvrebert cvrebert closed this Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.caret rendering problem in Firefox .caret is smaller in Firefox than other browsers
3 participants