New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button.js: Set disabled property in addition to disabled attribute #20278

Merged

cvrebert merged 1 commit into master from jq3-attr-prop

Jul 12, 2016

Commits on Jul 12, 2016

button.js: Set disabled property in addition to disabled attribute to…

… preserve behavior under jQuery 3

This code ought to have used .prop instead of .attr in the first place,
but we can't get rid of the attr manipulation now due to backward compatibility constraints.

Refs https://github.com/jquery/jquery-migrate/blob/3.0.0/warnings.md#jqmigrate-jqueryfnremoveattr-no-longer-sets-boolean-properties
Refs #16834

[skip validator]

cvrebert committed Jul 12, 2016