Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse module supports multi-target #21690

Closed
wants to merge 33 commits into from
Closed

Collapse module supports multi-target #21690

wants to merge 33 commits into from

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented Jan 12, 2017

Fixes #17643

This PR allow an <a> or <button> element to toggle multiple collapse area.
It preserve the ability to have a collapse being toggled by multiple <a> or <button>.

It relies on #21654 to handle collapse targets mo easily and efficiently (all the commits of #21654 are included here).

@pvdlg
Use css transition-duration in transitionEndEmulator
3af1b36
@pvdlg
Revert "Use css transition-duration in transitionEndEmulator"
b86686e 
This reverts commit 3af1b36.
@pvdlg
Use css transition-duration in transitionEndEmulator
a8a45e3
@pvdlg
Add support for transition: none and transition-duration: 0
f32f44f
@pvdlg
Set the default (emulated) transition to 350ms to match the default v…
d35d51d 
…alue of $transition-collapse
@pvdlg
Merge branch 'twbs/v4-dev' into use-css-transition-duration-in-js
fb1c6db
@pvdlg
Remove static duration in js modules
03ce98b 
Handle transition with multiple properties
Move shared transition handling in Util function
@pvdlg
Add unit test for collapse with long transition and no transition
2f7bc22
@pvdlg
Add unit test for alert with long transition and no transition
60bc69c
@pvdlg
Revert "Add unit test for alert with long transition and no transition"
785a59c 
This reverts commit 60bc69c.
@pvdlg
Add unit test for alert with long transition and no transition
bf359c5
@pvdlg
Handle transition on multiple elements (use the longest duration of a…
1af6581 
…ll the elements)
@pvdlg
Add unit test for modal with long transition and no transition
2017945
@pvdlg
Remove unnecessary checks on modal showBackdrop
69cefd3
@pvdlg
Merge branch 'twbs/v4-dev' into use-css-transition-duration-in-js
8be00b2
@pvdlg
Remove unnecessary reference to fade class
9f717a1
@pvdlg
Remove unnecessary removal of FADE and SHOW in setContent
e4a9a6f
@pvdlg
Rework getSelectorFromElement to not rely on regex
d60c557
@pvdlg
Simplify null check when possible
68de8f5
@pvdlg
Simplify targets.length test
89d2dcb
@pvdlg
Add a dropdown test case for twbs#21328
53ddc2a
@pvdlg
Merge branch 'use-css-transition-duration-in-js' into collapse-multi-…
aa8a15d 
…target
@pvdlg
Merge branch 'fix-getSelectorFromElement' into collapse-multi-target
411a201
@pvdlg
Util.TRANSITION_END doesn't need to be publicly accessible anymore
161b439
@pvdlg
Merge branch 'twbs/v4-dev' into use-css-transition-duration-in-js
c84355a
@pvdlg
Merge branch 'twbs/v4-dev' into collapse-multi-target
fb27bab
@pvdlg
Merge branch 'use-css-transition-duration-in-js' into collapse-multi-…
86991c1 
…target
@pvdlg
make getTargets to always return a JQuery to avoid calling JQuery on …
64e7b5b 
…the same element further down
@pvdlg
Merge branch 'twbs/v4-dev' into fix-getSelectorFromElement
8063c5a
@pvdlg
Merge branch 'fix-getSelectorFromElement' into collapse-multi-target
dd3371d 
# Conflicts:
#	js/src/alert.js
@pvdlg
Copy link
Contributor Author

pvdlg commented Jan 12, 2017

Some wrong commit added, Reopening...

@pvdlg pvdlg closed this Jan 12, 2017
@pvdlg pvdlg deleted the collapse-multi-target branch January 15, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pvdlg