fix segmented buttons #21716
Merged
fix segmented buttons #21716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed flex-direction to row centering is now done by align-items instead of justify-content this way there is no need for flex property on the .btn inside .btn-group
mdo
previously requested changes
Jan 16, 2017
| @@ -30,8 +30,8 @@ | |||
| .input-group .form-control { | |||
| // Vertically centers the content of the addons within the input group | |||
| display: flex; | |||
| flex-direction: column; | |||
| justify-content: center; | |||
| flex-direction: row; | |||
There was a problem hiding this comment.
This part can be dropped; it's the implicit default value of flex-direction.
There was a problem hiding this comment.
you're right
dropped it in a new commit
This was referenced Jan 16, 2017
Closed
bardiharborow
dismissed
mdo’s stale review
flex-direction has been dropped in a new commit.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21593 and fixes #21651.
changed flex-direction to row
centering is now done by align-items instead of justify-content
this way there is no need for flex property on the .btn inside .btn-group