Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit aria-label to placeholder-only inputs #22321

Merged
merged 3 commits into from
Apr 9, 2017
Merged

Add explicit aria-label to placeholder-only inputs #22321

merged 3 commits into from
Apr 9, 2017

Commits on Mar 30, 2017

  1. Add explicit aria-label to placeholder-only inputs

    While `placeholder` is nominally valid per spec
    http://rawgit.com/w3c/html-api-map/master/index.html#accessible-name-and-description-calculation
    it is inelegant, a fallback, and not supported in ios/safari/voiceover
    and android/chrome/talkback, to name a few combinations
    
    `aria-describedby` is also not really the right tool for providing a
    name/label equivalent, so remove that from the list of possible
    alternative methods / clarify how it can be used
    patrickhlauke committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    63cd4e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2017

  1. Configuration menu
    Copy the full SHA
    c5db196 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61536dd View commit details
    Browse the repository at this point in the history