Only change aria-pressed if it's not an input-based radio or checkbox group #22400
Conversation
… group aria-pressed="true"/aria-pressed="false" is really only useful for making on/off toggles out of, say, `<button>` elements. the attribute is useless (and potentially confusing/conflicting) on, say, `<label>` elements for an existing `<input type="radio">` or similar.
|
@Johann-S ah yes, good call on unit tests. will get on that this morning |
|
@Johann-S mind having a look over the unit test i just added? admittedly, i'm not so hot on qunit nor clean jquery, so likely i'm going about this in an unnecessarily convoluted way. however, i have run the unit test against the current v4-dev, where it fails (because current v4 DOES add those |
|
It seems you let some trailing spaces see : https://travis-ci.org/twbs/bootstrap/jobs/220509346#L220 But your unit test is fine 👍 |
|
@Johann-S cool. trailing spaces killed. will go ahead and merge. thank you :) |
aria-pressed="true"/aria-pressed="false"is really only useful for making on/off toggles out of, say,<button>elements. the attribute is useless (and potentially confusing/conflicting) on, say,<label>elements for an existing<input type="radio">or similar.closes #22040