Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousel "hover" behavior on touch-enabled devices #22442

Merged
merged 3 commits into from
Apr 17, 2017
Merged

Fix carousel "hover" behavior on touch-enabled devices #22442

merged 3 commits into from
Apr 17, 2017

Commits on Apr 14, 2017

  1. Add carousel mouse listeners even if touch events enabled

    - touch events are enabled not just on "mobile", just also on
    touch-enabled desktop/laptop devices; additionally, it's possible to
    pair a mouse with traditionally touch-only devices (e.g. Android
    phones/tablets); currently, in these situations the carousel WON'T pause
    even when using a mouse
    patrickhlauke committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    0587d2d View commit details
    Browse the repository at this point in the history
  2. Restart cycle after touchend

    as `mouseenter` is fired as part of the touch compatibility events, the
    previous change results in carousels which cycle until the user
    tapped/interacted with them. after that they stop cycling (as
    `mouseleave` is not sent to the carousel after user scrolled/tapped
    away).
    this fix resets the cycling after `touchend` - essentially returning
    to the previous behavior, where on touch the carousel essentially never
    pauses, but now with the previous fix it at least pauses correctly for
    mouse users on touch-enabled devices.
    includes documentation for this new behavior.
    patrickhlauke committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    cd6d4a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. Configuration menu
    Copy the full SHA
    c5359eb View commit details
    Browse the repository at this point in the history