Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak iOS hack for dropdown #22482

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Tweak iOS hack for dropdown #22482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9521a4
Tweak iOS hack for dropdown
patrickhlauke Apr 20, 2017
14882f5
Merge branch 'v4-dev' into v4-dev-dropdown-backdrop-ios-fix2
patrickhlauke Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/src/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const Dropdown = (($) => {
// https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html
if ('ontouchstart' in document.documentElement &&
!$(parent).closest(Selector.NAVBAR_NAV).length) {
$('body').children().on('mouseover', '*', $.noop)
$('body').children().on('mouseover', null, $.noop)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just omit the 2nd argument in this case. Right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but i thought i'd make it explicit (since that's what tripped up an earlier review)

}

this.focus()
Expand Down Expand Up @@ -190,7 +190,7 @@ const Dropdown = (($) => {
// if this is a touch-enabled device we remove the extra
// empty mouseover listeners we added for iOS support
if ('ontouchstart' in document.documentElement) {
$('body').children().off('mouseover', '*', $.noop)
$('body').children().off('mouseover', null, $.noop)
}

toggles[i].setAttribute('aria-expanded', 'false')
Expand Down