Fixed #21237 - Toggle buttons don't honor [disabled] or .disabled #22499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/src/button.js
Outdated
| @@ -90,6 +90,11 @@ const Button = (($) => { | |||
| } | |||
|
|
|||
| if (triggerChangeEvent) { | |||
| if (input.disabled || rootElement.disabled || | |||
There was a problem hiding this comment.
there shouldn't be a need to check if the element is actually disabled, as this would only be exposed for elements that actually support the disabled attribute (e.g. <button>), and those elements wouldn't trigger the click event anyway when clicked)
There was a problem hiding this comment.
@patrickhlauke done!
Johann-S
requested changes
Apr 25, 2017
|
@Johann-S, tests added |
Johann-S
approved these changes
Apr 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check for disabled attributes and classes on the button element.
Close : #21237