Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: accessibility and IE fixes for SVG-based top navigation #22848

Merged
merged 4 commits into from
Jun 17, 2017
Merged

Docs: accessibility and IE fixes for SVG-based top navigation #22848

merged 4 commits into from
Jun 17, 2017

Commits on Jun 17, 2017

  1. Add explicit aria-label attributes to <svg> based links 

    As some browser/AT combinations don't seem to fully support grabbing the
`<title>` from inside the `<svg>` as the link text/name to announce
(e.g. Firefox+NVDA)
    @patrickhlauke
    patrickhlauke committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    a6ae35f View commit details
    Browse the repository at this point in the history

  2. Add <title> to Bootstrap logo <svg>

    @patrickhlauke
    patrickhlauke committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    dd2ee79 View commit details
    Browse the repository at this point in the history

  3. Add <title> to menu <svg>

    @patrickhlauke
    patrickhlauke committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    0eec115 View commit details
    Browse the repository at this point in the history

  4. Add explicit focusable="false" to <svg> icons 

    Due to a bug/"feature" in IE, `<svg>` elements are usually separately
focusable, which then results in links with `<svg>` icons being
essentially focused twice (once for the link, and once for the `<svg>`
inside, which is then also non-interactive)
    @patrickhlauke
    patrickhlauke committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    12e7af4 View commit details
    Browse the repository at this point in the history