Fix to Chrome inheritance bug (#22872) #23118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Jul 18, 2017
scss/_reboot.scss
Outdated
| @@ -19,7 +19,7 @@ | |||
| // 6. Change the default tap highlight to be completely transparent in iOS. | |||
|
|
|||
| html { | |||
| box-sizing: border-box; // 1 | |||
| box-sizing: inherit; // 1 | |||
There was a problem hiding this comment.
This should just be removed outright, and the comments above updated.
There was a problem hiding this comment.
Ok I am on it. I don't think we need to update comments. As the comments are still correct.
We can put html selector after the wildcard selectors so that the order of comments is meaningful.
There was a problem hiding this comment.
This is done. Let me know if any other changes are required.
box-sizing removed from html and order of wild card selected and html selector swapped to maintain correctness of comments.
mdo
approved these changes
Jul 19, 2017
|
Ok thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed:
to
Also, to address duplication of
box-sizingfrom thehtmlselector above, changedbox-sizing:border-box;tobox-sizing:inherit;fromhtml.Fixes #22872.
Resolves the issue with PR #23025.