Reduce number of spacing rules #23208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Aug 3, 2017
scss/utilities/_spacing.scss
Outdated
| .mx#{$infix}-auto { | ||
| margin-right: auto !important; | ||
| margin-left: auto !important; | ||
| margin-right: auto !important; |
There was a problem hiding this comment.
Can you remove the spaces after : that don't make sense to have like here and the other places you edited?
|
During my testing I saw a reduction 6,228 bytes in the minified file by combining the x & y rules with the t, r, b, l rules |
mdo
approved these changes
Aug 11, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to reduce the number of generated spacing rules. We do this by combining x & y rules with top, bottom, right, and left rules