Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs Rubygems version to beta #23289

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Update docs Rubygems version to beta #23289

merged 2 commits into from
Aug 11, 2017

Conversation

kukac7
Copy link
Contributor

@kukac7 kukac7 commented Aug 11, 2017

Fixes #23292

@@ -68,13 +68,13 @@ Bootstrap's `package.json` contains some additional metadata under the following
Install Bootstrap in your Ruby apps using [Bundler](https://bundler.io/) (**recommended**) and [RubyGems](https://rubygems.org/) by adding the following line to your [`Gemfile`](https://bundler.io/gemfile.html):

{% highlight ruby %}
gem 'bootstrap', '~> 4.0.0.alpha6'
gem 'bootstrap', '~> 4.0.0.beta'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it beta1 instead of beta ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it is: gem 'bootstrap', '~> 4.0.0.beta'
https://github.com/twbs/bootstrap-rubygem/blob/master/README.md

Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kukac7: please update the version in index.html too.

@XhmikosR XhmikosR changed the title docs version fixing Update docs Rubygems version to beta Aug 11, 2017
@kukac7
Copy link
Contributor Author

kukac7 commented Aug 11, 2017

@XhmikosR #23300

@XhmikosR
Copy link
Member

Sorry that is just wrong. Push here.

@XhmikosR
Copy link
Member

I went ahead and did it manually, but it would be nice if you got the gist of how things work for future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants