Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run docs-github script. #23688

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Conversation

XhmikosR
Copy link
Member

$npm_config_tmp is a non-existent variable.
Also, use double quotes since single ones don't work.
Finally, git ignore the temp file.

`$npm_config_tmp` is a non-existent variable.
Also, use double quotes since single ones don't work.
Finally, git ignore the temp file.
@XhmikosR XhmikosR merged commit 8876334 into v4-dev Aug 26, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-fix-npm-run-docs-github branch August 26, 2017 09:59
@mdo mdo mentioned this pull request Aug 26, 2017
@bardiharborow
Copy link
Member

This workaround is fine, but you should lodge a bug report with NPM for your platform if $npm_config_tmp doesn't exist in a npm run context, as that's very much intended behaviour.

@XhmikosR
Copy link
Member Author

Nah. no time for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants