Making the customization option docs clearer about variable overrides #24033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with !default flag
|
@Bobeta Thanks for sending this PR. It' be awesome if you could add a code snippet to show exactly how to load your variables before bootstrap's. It can be something silly like: // Your variables overwrite first
$body-bg: #f00;
// Then import Bootstrap
@import "node_modules/bootstrap/scss/bootstrap";or whatever you think it's best to drive the point better. What do you think? |
|
@andresgalante Sure mate, I baked in the examples from the next paragraph so that we don't repeat ourselves |
docs/4.0/getting-started/options.md
Outdated
| $body-bg: $gray-900; | ||
| $body-color: $gray-600; | ||
| // Your variable overwrite first or a Sass file containing the modifications | ||
| $body-bg: #000000; |
There was a problem hiding this comment.
I'd change this to #000 and #111 just to follow bootstrap coding guidelines
There was a problem hiding this comment.
@andresgalante You're right, did that with the new commit
XhmikosR
approved these changes
Sep 27, 2017
|
@Johann-S: LGTM. Please merge if you agree too. |
Closed
mdo
added a commit
that referenced
this pull request
Sep 30, 2017
I believe #24033 is factually inaccurate, while also containing some typos and grammar problems This PR addresses a couple things: - Variable overrides can come before or after you import Bootstrap—they'll still override the default value in our code. - Removed the double `::` at the end of the paragraph. - Fixed usage of `overwrite` when we mean `override`. /cc @Johann-S @XhmikosR
mdo
added a commit
that referenced
this pull request
Sep 30, 2017
I believe #24033 is factually inaccurate, while also containing some typos and grammar problems. This PR addresses a few things: - Variable overrides can come before or after you import Bootstrap—they'll still override the default value in our code. - Removed the double at the end of the paragraph. - Fixed usage of when we mean . /cc @Johann-S @XhmikosR @Bobeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docs on the subject can easily be interpreted as the user should import their modified variables after importing bootstrap sass files, this PR aims to make it clearer #23963