Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style for non-overlapping scrollbar in IE #24081

Merged
merged 3 commits into from
Sep 26, 2017
Merged

Add style for non-overlapping scrollbar in IE #24081

merged 3 commits into from
Sep 26, 2017

Conversation

prateekgoel
Copy link
Contributor

@prateekgoel prateekgoel commented Sep 25, 2017

Added -ms-overflow-style: scrollbar; to resolve overlapping scrollbar issue in IE 11 and Edge.

Fixes #24057

Before
image

After
image

@Johann-S
Copy link
Member

Not sure if this change should be applied to Bootstrap or to our docs CSS 🤔

@XhmikosR XhmikosR requested a review from mdo September 25, 2017 20:34
@XhmikosR
Copy link
Member

Does the issue happen in all pres? If so I guess it makes sense to add it in reboot otherwise only docs.

@prateekgoel
Copy link
Contributor Author

Yes, it happens in all.
It's safe to add in reboot.

@XhmikosR
Copy link
Member

@Johann-S: can you confirm?

@Johann-S
Copy link
Member

yep I reproduced that bug on Win7 IE 11, but to see it you have to move your cursor over our <pre> and it's only for long <pre>s

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go other than this one formatting comment...

@@ -239,6 +239,9 @@ pre {
margin-bottom: 1rem;
// Don't allow content to break outside
overflow: auto;
// We have @viewport set which causes scrollbars to overlap content in IE11 and Edge, so
// we force a non-overlapping, non-auto-hiding scrollbar to counteract.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many spaces here between // and we.

@XhmikosR
Copy link
Member

@prateekgoel: please don't remove the option to allow project members to edit your PRs.

@prateekgoel
Copy link
Contributor Author

Yes @XhmikosR . I mistakenly unchecked that option.
I have removed the extra spaces as mentioned by @mdo.

@XhmikosR XhmikosR merged commit 0e054fb into twbs:v4-dev Sep 26, 2017
@mdo mdo mentioned this pull request Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants