Collapse - Allow to pass jQuery object or DOM element to the parent option #24083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
v4-collapse-parent
branch
from
9df5d5e
to
7dfafff
Compare
vsn4ik
reviewed
Sep 25, 2017
| parent = this._config.parent | ||
|
|
||
| // it's a jQuery object | ||
| if (typeof this._config.parent.jquery !== 'undefined') { |
There was a problem hiding this comment.
Maybe
typeof this._config.parent.jquery !== 'undefined'
->
this._config.parent instanceof jQuery
?
XhmikosR
approved these changes
Sep 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass jQuery object or DOM element to the parent option
Close : #24073