Vertical aligns horizontal forms using flex instead of math #24333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
force-pushed
the
v4-dev-andres-form-alignment
branch
from
938a1e8
to
4c99da1
Compare
|
I haven't thought about Form row :( I'll close it till I find a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes vertical alignment of labels on horizontal forms from paddings and clac to a more robust solution with flex. Let's let the computer do the math 😄
The visual result is the same.
This PR is related to #24328
@XhmikosR @mdo what do you guys think?