Add dispose methods in our documentation #24396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
v4-dev-johann-docs-dipose
branch
from
4b89ea8
to
93c8212
Compare
XhmikosR
reviewed
Oct 16, 2017
docs/4.0/components/buttons.md
Outdated
| @@ -154,4 +154,5 @@ Note that pre-checked buttons require you to manually add the `.active` class to | |||
|
|
|||
| | Method | Description | | |||
| | --- | --- | | |||
| | `$().button('toggle')` |Toggles push state. Gives the button the appearance that it has been activated. | | |||
| | `$().button('toggle')` | Toggles push state. Gives the button the appearance that it has been activated. | | |||
There was a problem hiding this comment.
Nitpicking here and in the next line there are 2 spaces before the end |.
XhmikosR
approved these changes
Oct 16, 2017
|
@Johann-S; don't forget to choose squash + merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #24188