Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Tooltips/Popovers in Shadow DOM #25150

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

Johann-S
Copy link
Member

Fixes : #24918

@Johann-S
Copy link
Member Author

Johann-S commented Jan 3, 2018

ping @XhmikosR

@XhmikosR
Copy link
Member

XhmikosR commented Jan 3, 2018

@Johann-S: I'm not familiar with shadow DOM at all, so I'm not sure I can be of any help...

@Johann-S Johann-S force-pushed the v4-dev-johann-shadow branch 2 times, most recently from 191a487 to 6490c0d Compare January 11, 2018 08:44
@Johann-S
Copy link
Member Author

This is a live example : https://codepen.io/Johann-S/pen/ZvxgLZ

if @ericcarino or @LMOkino can take a look and see if it works as you wanted it would be perfect 👍

@LMOkino
Copy link

LMOkino commented Jan 11, 2018

Johann, it looks good. Please let us know when it is in the bootstrap code.

@Johann-S
Copy link
Member Author

@mdo if you have time to check that change, it seems it works pretty well

@mdo
Copy link
Member

mdo commented Jan 16, 2018

Is this intentional?

screen shot 2018-01-15 at 9 34 22 pm

@Johann-S
Copy link
Member Author

Yep it's to show that if you use container option to append into the Shadow DOM you'll loose Bootstrap's style but if you include Bootstrap CSS in your Shadow DOM it should be fine

js/src/tooltip.js Outdated Show resolved Hide resolved
@Johann-S
Copy link
Member Author

Johann-S commented Nov 9, 2018

Maybe we can integrate some optimisations from jQuery: jquery/jquery#3996

@Johann-S Johann-S requested a review from a team as a code owner December 5, 2018 09:11
@Johann-S
Copy link
Member Author

Johann-S commented Dec 5, 2018

@XhmikosR I rebased here, and made some changes, maybe we should add information in our docs ?

@XhmikosR
Copy link
Member

XhmikosR commented Dec 5, 2018

Yup, we should mention it in docs. Can you add some basic info?

@Johann-S
Copy link
Member Author

Johann-S commented Dec 5, 2018

Done 👍

@Johann-S Johann-S merged commit b16127f into v4-dev Dec 5, 2018
@Johann-S Johann-S deleted the v4-dev-johann-shadow branch December 5, 2018 15:03
@mdo mdo mentioned this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants