Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverall to follow our coverage #25929

Merged
merged 1 commit into from
May 23, 2018
Merged

Add coverall to follow our coverage #25929

merged 1 commit into from
May 23, 2018

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Mar 23, 2018

Hey guys !

I want to add Coverall to our repository because it'll help us to follow our coverage by adding a badge in our README.md plus it'll add comments in PRs which will indicate if our coverage is lower than before.

@mdo if you're ok with that, please see :

Edit:

Currently we have that, but it's normal :

image

/CC @XhmikosR @bardiharborow @cvrebert

@Johann-S Johann-S requested review from mdo and XhmikosR March 23, 2018 14:30
@Johann-S Johann-S force-pushed the v4-dev-johann-coverall branch 2 times, most recently from e9fd3bc to ae4f36a Compare March 23, 2018 14:50
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should add the badge before merging :)

@XhmikosR
Copy link
Member

@mdo: ping

@Johann-S
Copy link
Member Author

Johann-S commented May 1, 2018

ping @mdo we need you 🙏 😆

@XhmikosR
Copy link
Member

@Johann-S: I added this myself. Can you rebase?

@XhmikosR
Copy link
Member

Oh, and add the badge in README too.

@Johann-S
Copy link
Member Author

Thanks @XhmikosR, I added the badge 😉

@Johann-S Johann-S merged commit 31cf1fd into v4-dev May 23, 2018
@Johann-S Johann-S deleted the v4-dev-johann-coverall branch May 23, 2018 08:03
@mdo mdo mentioned this pull request May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants