Update dependencies. #26658
Merged
Update dependencies. #26658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
4 times, most recently
from
2ac1ea5
to
5a79226
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
2 times, most recently
from
4db2e54
to
0faf276
Compare
|
@hzoo: do you know how to fix these errors after beta45? |
Hm never seen that before, maybe related to loganfsmyth/babel@2cbfc34#diff-f93fbf6dce06b5cbf6cc65f5f7dac101? @loganfsmyth? |
|
@hzoo Filed: babel/babel#8182 |
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
0faf276
to
c98ff5a
Compare
Newer bundlesize versions still don't work with node.js 10.x. babel has some bugs that we need to be fixed.
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
c98ff5a
to
deaa697
Compare
|
Thanks @hzoo and @loganfsmyth. Until we have a new release with this fix and the Windows RegExp fixes, I'm gonna stay with beta.44. @Johann-S please review so that we merge this. |
Merged
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
826c169
to
deaa697
Compare
I was getting port in use errors.
Johann-S
approved these changes
Jun 21, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Johann-S: the babel ones is what I haven't tested thoroughly. We need to read the release notes in case we need to update our config or something. Also, make sure you are using node 10.3.0 which ships with npm 6.3.1.