feature(carousel): carousel-item interval #26667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
requested changes
Jun 6, 2018
js/src/carousel.js
Outdated
| @@ -385,6 +385,20 @@ const Carousel = (($) => { | |||
| $(activeElement).addClass(directionalClassName) | |||
| $(nextElement).addClass(directionalClassName) | |||
|
|
|||
| if ($(nextElement).data('interval')) { | |||
There was a problem hiding this comment.
Please use more vanilla JS and change that line by
const nextElementInterval = nextElement.getAttribute('data-interval')
if (nextElementInterval) {
js/src/carousel.js
Outdated
| { | ||
| interval : '(number|boolean)' | ||
| }) | ||
| this._config.defautlInterval = this._config.defautlInterval || this._config.interval |
There was a problem hiding this comment.
typo here, it's not defautlInterval but defaultInterval
js/src/carousel.js
Outdated
| interval : '(number|boolean)' | ||
| }) | ||
| this._config.defautlInterval = this._config.defautlInterval || this._config.interval | ||
| this._config.interval = $(nextElement).data('interval') |
There was a problem hiding this comment.
Here instead of get the value from the dom use nextElementInterval
|
There are a lots of things to do before we accept this MR :
|
|
Here is a CodePen displaying this functionality. |
Johann-S
approved these changes
Jun 7, 2018
|
very nice @morrissey-ingenious 👍 I want the feedbacks from other members before merging your PR /CC @XhmikosR, @patrickhlauke, @mdo |
XhmikosR
approved these changes
Jun 11, 2018
adds the ability to assign data-interval to an individual carousel-item
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to assign data-interval to an individual carousel-item.
I'm aware this may not be the proper way to add this functionality so please comment and give feedback and suggestions so that I can modify this pull request.
thanks