Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pointer-events on disabled anchor dropdown-item #26700

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Prevent pointer-events on disabled anchor dropdown-item #26700

merged 2 commits into from
Sep 26, 2018

Conversation

howardcox
Copy link
Contributor

Fixes #26695

@howardcox howardcox force-pushed the disabled-anchors-26695 branch 3 times, most recently from 8381a15 to 1ab4187 Compare June 12, 2018 07:51
@andresgalante
Copy link
Collaborator

Why are you qualifying the selector?

You could add this under:

&.disabled,
  &:disabled {

on line 137. Or am I missing something?

andresgalante
andresgalante approved these changes Jun 19, 2018
View reviewed changes
Copy link
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @howardcox I've just patched your PR to have the desired result without the qualifying the selector.

Thanks a lot!

@howardcox
Copy link
Contributor Author

Thanks, sorry I was out-of-office until today otherwise I'd have patched it.

I originally qualified the selector with a because that's what _buttons.scss does for regular non-menu buttons.

@andresgalante
Copy link
Collaborator

Right, but even if dropdown-item is a btn I don't how it hurts to have the pointer events none there.

cc/ @patrickhlauke am I missing something?

@howardcox
Copy link
Contributor Author

Can this get merged at some point? It's missed 4.1.2 and 4.1.3

@XhmikosR
Copy link
Member

Ping @patrickhlauke

@jquense
Copy link
Contributor

jquense commented Aug 28, 2018

I'd expect list-group-item to also have this for consistency yeah?

@howardcox
Copy link
Contributor Author

Ok e8ac9ca adds this to _list-group.scss too

@XhmikosR
Copy link
Member

Ping @patrickhlauke

@XhmikosR XhmikosR merged commit d7f79b0 into twbs:v4-dev Sep 26, 2018
@mdo mdo mentioned this pull request Sep 26, 2018
Closed
@howardcox howardcox deleted the disabled-anchors-26695 branch December 31, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@andresgalante andresgalante andresgalante approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@howardcox @andresgalante @XhmikosR @jquense @patrickhlauke @Johann-S