Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel indicators transition #26902

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Carousel indicators transition #26902

merged 2 commits into from
Jul 25, 2018

Conversation

MartijnCuppens
Copy link
Member

Closes #26901

  • Added a $carousel-indicator-transition variable
  • Used opacity to prevent repaints while transitioning
  • Used the transition mixin

Demo: https://codepen.io/MartijnCuppens/pen/ajNXZj

@mdo mdo merged commit 4f92667 into twbs:v4-dev Jul 25, 2018
@mdo mdo mentioned this pull request Jul 25, 2018
Closed
@MartijnCuppens MartijnCuppens deleted the carousel-indicators-transition branch July 25, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresgalante andresgalante Awaiting requested review from andresgalante

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartijnCuppens @mdo @Johann-S