Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow-auto and overflow-hidden utilities #27268

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 19, 2018

New PR that replaces #26509 because the fork was deleted. This doesn't carbon-copy that PR's changes though. Instead, I've opted for two utilities to start—.overflow-auto and .overflow-hidden. No responsiveness, no x/y variants, and not every option. This PR also adds documentation which was missing from previous efforts.

I've also moved the $positions Sass list to the _variables.scss file alongside the new $overflows list. Folks can then customize both easily enough and gain more options.

Fixes #26479.

Copy link

@Hermanya Hermanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mdo mdo merged commit 29bd5e3 into v4-dev Oct 7, 2018
@mdo mdo deleted the overflow-auto-hidden branch October 7, 2018 00:56
@mdo mdo mentioned this pull request Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants